[IN PROGRESS] Working on Xcode 12.5 support #490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private headers changes: Added XCTTestIdentifierSet.h. Code changes: Added NSString+IdentifierString to make `identifierString` recognizable for NSString (workaround to avoid changing all related definations from NSString to XCTTestIdentifier).
XCTestManager_IDEInterface -> XCTMessagingChannel_RunnerToIDE XCTestDriverInterface -> XCTMessagingChannel_IDEToRunner XCTestManager_DaemonConnectionInterface -> XCTMessagingChannel_IDEToDaemon
|
Superseded by #497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Correct protocol mapping
XCTestManager_IDEInterface -> XCTMessagingChannel_RunnerToIDE
XCTestDriverInterface -> XCTMessagingChannel_IDEToRunner
XCTestManager_DaemonConnectionInterface -> XCTMessagingChannel_IDEToDaemon
Add the references to the headers
Add the implementation of the protocol functions