Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Xcode 12.5 #497

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Support for Xcode 12.5 #497

merged 1 commit into from
Jun 22, 2021

Conversation

ob
Copy link
Member

@ob ob commented Jun 21, 2021

This is the final form of #491, fixes #488

* Switch CI to macOS 11

Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
@ob ob self-assigned this Jun 21, 2021
@chenxiao0228
Copy link
Collaborator

Do we need all XCTest headers?

@ob
Copy link
Member Author

ob commented Jun 21, 2021

Do we need all XCTest headers?

Probably not but I figured it'd be easier to keep them since they will be regenerated again if you run class-dump and can make you think they are new when in fact they are not.

CHANGELOG.md Show resolved Hide resolved
Copy link

@shepting shepting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenxiao0228
Copy link
Collaborator

Probably not but I figured it'd be easier to keep them since they will be regenerated again if you run class-dump and can make you think they are new when in fact they are not.

Maybe let's follow up by automating the dumping and replacing process.

@chenxiao0228 chenxiao0228 merged commit 2bbc979 into master Jun 22, 2021
@shepting
Copy link

@ob What's your Venmo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 12.5 support
3 participants