Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: Update missing_trip_edge rule to create exception #1755

Closed
1 task
emmambd opened this issue May 9, 2024 · 1 comment · Fixed by #1843
Closed
1 task

Flex: Update missing_trip_edge rule to create exception #1755

emmambd opened this issue May 9, 2024 · 1 comment · Fixed by #1843
Assignees
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex.

Comments

@emmambd
Copy link
Contributor

emmambd commented May 9, 2024

Describe the problem

In order to support Flex as a part of #1721, we need to create an exception for the missing_trip_edge rule.

Depends on #1749

Proposed solution

  • Add exception for missing_trip_edge rule:
File name Spec language Notice to update or add Validator logic Notice table columns
stop_times.txt arrival_time, departure_time

Forbidden** when `start_pickup_drop_off_window` or `end_pickup_drop_off_window` are defined.

missing_trip_edge If a trip has a start_pickup_dropoff_window or end_pickup_drop_off_window, do not trigger this error.

Test with https://data.trilliumtransit.com/gtfs/islandtransit-wa-us/islandtransit-wa-us--flex-v2-TEST.zip to make sure the error is not triggered.

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels May 9, 2024
@emmambd emmambd changed the title Flex: Update stop time schema and missing_trip_edge rule to create exception Flex: Update missing_trip_edge rule to create exception May 9, 2024
@emmambd emmambd added the flex Rules and rule changes related to GTFS-Flex. label May 9, 2024
@jcpitre jcpitre self-assigned this May 13, 2024
@emmambd emmambd added this to the Flex: modifying pre-existing rules milestone May 14, 2024
@emmambd emmambd added status: Blocked Can't work on it currently because of an external factor. and removed status: Needs triage Applied to all new issues labels May 16, 2024
@emmambd emmambd modified the milestones: Flex: modifying pre-existing rules, 6.0 Validator Release May 30, 2024
@emmambd emmambd added the flex-2 label Sep 3, 2024
@emmambd emmambd removed the flex-2 label Sep 9, 2024
@emmambd emmambd removed the status: Blocked Can't work on it currently because of an external factor. label Sep 13, 2024
@cka-y cka-y self-assigned this Sep 23, 2024
@qcdyx
Copy link
Contributor

qcdyx commented Sep 23, 2024

Tasks:

  • add the logic to make sure this error doesn't get triggered for flex feeds
  • add tests
  • review acceptance tests

@cka-y cka-y linked a pull request Sep 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature flex Rules and rule changes related to GTFS-Flex.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants