Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic route add #31

Closed
wants to merge 1 commit into from

Conversation

hellorachid
Copy link

when a user doesn't create routes and he wanna add dynamic route subroute throw error because the varibale routes is undifined
example :
var browserModule = new Backbone.SubRoute("browser",{createTrailingSlashRoutes: true});
browserModule.route('browse',function(){console.log('browse');})

when a user doesn't create routes and he wanna add dynamic route subroute throw error because the varibale routes is undifined 
example : 
var browserModule = new Backbone.SubRoute("browser",{createTrailingSlashRoutes: true});
	browserModule.route('browse',function(){console.log('browse');})
geekdave added a commit that referenced this pull request Dec 31, 2013
geekdave added a commit that referenced this pull request Dec 31, 2013
@geekdave
Copy link
Contributor

Thanks for the fix, @hellorachid ! I've merged it in a separate PR, since I needed to add a unit test for this case in order to get code coverage to pass.

@geekdave geekdave closed this Dec 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants