Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete metadata annotation tool #116

Merged
merged 17 commits into from
Apr 12, 2019
Merged

Complete metadata annotation tool #116

merged 17 commits into from
Apr 12, 2019

Conversation

jonc125
Copy link
Contributor

@jonc125 jonc125 commented Mar 22, 2019

Will fix #65.

The steps required are listed in that issue.

- update the working tree too
- remove untracked files within the function
@ghost ghost assigned jonc125 Mar 22, 2019
@ghost ghost added the in progress label Mar 22, 2019
@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #116 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #116     +/-   ##
========================================
+ Coverage    94.8%   95.4%   +0.5%     
========================================
  Files          50      50             
  Lines        2017    2215    +198     
  Branches      214     266     +52     
========================================
+ Hits         1914    2114    +200     
+ Misses         76      72      -4     
- Partials       27      29      +2
Impacted Files Coverage Δ
weblab/entities/urls.py 100% <ø> (ø) ⬆️
weblab/entities/templatetags/entities.py 100% <ø> (ø) ⬆️
weblab/entities/views.py 95.4% <100%> (+2.4%) ⬆️
weblab/entities/repository.py 98.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79df6d3...f94f6e4. Read the comment docs.

@jonc125 jonc125 marked this pull request as ready for review March 29, 2019 15:17
@jonc125 jonc125 requested a review from helenst March 29, 2019 15:20
@jonc125
Copy link
Contributor Author

jonc125 commented Mar 29, 2019

@mirams @MichaelClerx I've now deployed this branch on scrambler - please have a play when you get a minute and see if it looks OK from a user's pov.

@jonc125 jonc125 changed the base branch from 65-new-version-view to master April 1, 2019 15:56
...demonstrating that commit.parents wasn't getting what I thought
it was!
@helenst
Copy link
Contributor

helenst commented Apr 3, 2019

👍 Code looks good to me now

@MichaelClerx
Copy link
Contributor

Seems to work well!
Can I put in a feature request for a search box above both trees? Ideally it'd have an autocomplete list hanging off, and selecting an item would then open the tree at the correct place

@jonc125
Copy link
Contributor Author

jonc125 commented Apr 12, 2019

You can certainly open an issue for that @MichaelClerx :)

@jonc125 jonc125 merged commit f2c1dae into master Apr 12, 2019
@jonc125 jonc125 deleted the 65-alter-file-view branch April 12, 2019 16:13
MauriceHendrix pushed a commit that referenced this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the model annotation tool
4 participants