Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable or get rid of long tests #181

Closed
3 tasks done
MichaelClerx opened this issue May 3, 2020 · 3 comments
Closed
3 tasks done

Re-enable or get rid of long tests #181

MichaelClerx opened this issue May 3, 2020 · 3 comments
Labels
long term Low priority issues that need solving _eventuall_

Comments

@MichaelClerx
Copy link
Contributor

MichaelClerx commented May 3, 2020 •
edited
Loading

Currently no strategy for running tests marked with

#@pytest.mark.skipif(os.getenv('FC_LONG_TESTS', '0') == '0', reason="FC_LONG_TESTS not set to 1")

Namely:

  • test_ical_proto.py::test_ical --> Passes when run
  • test_s1s2_protocol.py::test_s1_s2
  • test_python_reproducibility.py --> Separate issue Run TestPythonReproducibility #24
@MichaelClerx
Copy link
Contributor Author

The first two work, the third is a separate issue.

@jonc125 Do we keep these tests and set up an cron job or delete them?

@MichaelClerx MichaelClerx mentioned this issue May 3, 2020
Closed
@jonc125
Copy link
Contributor

jonc125 commented May 4, 2020 •
edited by MichaelClerx
Loading

Set up a cron job for them I think. We'll need it for #24 certainly.

@MichaelClerx MichaelClerx mentioned this issue May 4, 2020
Open
4 tasks
@MichaelClerx MichaelClerx mentioned this issue Jul 13, 2020
Closed
@jonc125 jonc125 added the long term Low priority issues that need solving _eventuall_ label Aug 28, 2020
@jonc125
Copy link
Contributor

jonc125 commented Oct 21, 2020

Closing this as it's covered in #24.

@jonc125 jonc125 closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
long term Low priority issues that need solving _eventuall_
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelClerx @jonc125