Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-positionsticky test returns true when there is partial support for sticky positioning #1111

Closed
facundocabrera opened this issue Nov 22, 2013 · 5 comments

Comments

@facundocabrera
Copy link

Hey,

I'm working with an app which require some kind of "fixed column" support in tables.
The initial idea was simulate the floating column using position: sticky but I found a problem, the test we currently have reports true when there is "partial" support.

Please check this gist where I'll show 2 examples, 1st works "cross-browser", and the second one fails in iOS6 and Chrome Canary.

https://gist.github.com/dendril/7606300#file-sticky-test-html

NOTE: the combination position: sticky; top: x; works without any problem. In my case I found the issue because I'm defining left: x; instead.

@phistuck
Copy link
Contributor

Can you file an issue regarding the partial support in crbug.com? thank you!

@patrickkettner
Copy link
Member

done here, please star to help boost up its priority :D

@patrickkettner
Copy link
Member

that bug has been updated as fixed - https://code.google.com/p/chromium/issues/detail?id=322972.

@stucox - not sure if we should be returning true or not. I don't think this is as broken as the flexbox stuff, but I think that a vast majority of uses are the standard top down, and therefor unaffected by this (now resolved) bug

@stucox
Copy link
Member

stucox commented Mar 5, 2014

May be fixed in Blink but it could be a while before it’s fixed in iOS too – although the bug only occurs in certain conditions and @dendril has shown a workaround.

As @patrickkettner says, position: sticky works for the majority of common use cases in these browsers, so I think Modernizr.csspositionsticky should still return true.

Can we record this issue on caniuse.com?

@patrickkettner
Copy link
Member

Sent feedback to @Fyrd, I'll submit a PR adding this to the knownBugs section of the test

patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Mar 9, 2014
patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Mar 11, 2014
patrickkettner added a commit that referenced this issue Mar 26, 2014
add sticky positioning knownBug, fixes #1111
patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
patrickkettner added a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants