Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test for position: (-webkit-)sticky support #676

Merged
merged 1 commit into from
Aug 31, 2012

Conversation

phistuck
Copy link
Contributor

WebKit just (latest Chromium nightlies have it) added an experimental
support for the newly proposed position: sticky as position:
-webkit-sticky.
Proposal and discussion -
http://lists.w3.org/Archives/Public/www-style/2012Jun/0627.html

WebKit just (latest Chromium nightlies have it) added an experimental
support for the newly proposed position: sticky as position:
-webkit-sticky.
Proposal and discussion -
http://lists.w3.org/Archives/Public/www-style/2012Jun/0627.html
@travisbot
Copy link

This pull request passes (merged 3fb7217 into aea240b).

@paulirish
Copy link
Member

Thank you! I think this project has moved to multiple var declarations, though I feel like we haven't documented that. So not your fault. I'll pull this and address myself.

Thanks again for the pull request!

paulirish added a commit that referenced this pull request Aug 31, 2012
Adds a test for position: (-webkit-)sticky support
@paulirish paulirish merged commit cf49585 into Modernizr:master Aug 31, 2012
@phistuck
Copy link
Contributor Author

Happy to help. :)

@facundocabrera
Copy link

Hey,

I have been working with this property and I was under a particular problem, in iOS 6 the sticky support is partial because it only resolve the top property. In iOS 7 the property is work as expected.

Scenario:

.sticky {
    position: -webkit-sticky;
    position: sticky;
    left: 0;
}

Should the test continue returning true instead of false in this particular case?

@patrickkettner
Copy link
Member

Could you show an example that exhibits the issue?

@facundocabrera
Copy link

Hey! Thanks for your fast answer:

Steps I'm using for test:

  1. git clone git@github.com:dendril/jquery.fixedcolumn.git
  2. bower install
  3. comment this line: https://github.com/dendril/jquery.fixedcolumn/blob/master/jquery.fixedcolumn.js#L13
  4. try it in iOS6 (in my personal case I have a iPad with iOS 6.1 and another with iOS 7 to play with)

Reported error: The grey column disappear if you scroll to the left, and it must be always visible.
Note: if you change the example to a vertical scroll scenario, it will work as expected.

Hope this extra information will help 😄

@facundocabrera
Copy link

Today I have had the chance to test Chrome Canary (33.0.1716.0) enabling the "Experimental Web Platform..." and it's having the same issue as iOS6 (only support top property for now).

@patrickkettner
Copy link
Member

Would you mind opening up a new issue with this information?

@facundocabrera
Copy link

No problem, I have finally found a hacky solution using CSS.

https://gist.github.com/dendril/7606300#file-sticky-test-html

Let me know if you still want to open a bug to share this with others :)

@patrickkettner
Copy link
Member

Well we want to see if we can improve the test, if it is in fact misleading. So yes, please do.

On Fri, Nov 22, 2013 at 3:33 PM, Facundo Cabrera notifications@github.com
wrote:

No problem, I have finally found a hacky solution using CSS.
https://gist.github.com/dendril/7606300#file-sticky-test-html

Let me know if you still want to open a bug to share this with others :)

Reply to this email directly or view it on GitHub:
#676 (comment)

@facundocabrera
Copy link

The history continue in #1111

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
Adds a test for position: (-webkit-)sticky support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants