Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode-range tests returns false negative on firefox beta in linux #1588

Closed
ryanseddon opened this issue May 1, 2015 · 6 comments
Closed

Comments

@ryanseddon
Copy link
Member

Firefox beta (v38) now supports unicode ranges that doesn't require enabling a flag.

Our unicode test returns a false negative because linux doesn't have arial and fallsback to the monospace font.

@patrickkettner
Copy link
Member

so, layout.css.unicode-range.enabled is actually false in Firefox 38 in sauce. But is is true in firefox 39.

@patrickkettner
Copy link
Member

In addition, the caniuse tests actually seem to be failing in firefox 39. I think this may actually be a false false negative

image

@ryanseddon
Copy link
Member Author

Firefox 39 does support unicode-ranges but i think it has bugs. However this issue will still false negative in FF40 on linux due to the nature of the test using a font that doesn't exist on linux.

@patrickkettner
Copy link
Member

firefox 38 had unicode-range enabled as well. it seems that it is enabled on dev and disabled later on down the release train.

"arial" doesn't really mean arial. in actually loads Liberation Sans on (most) linux if you were to set it to set its font property directly. This is one of the reasons its a "web safe" font.

Our test is failing in firefox 40, but so is every unicode-range demo I can find (including caniuse).

@ryanseddon
Copy link
Member Author

But that's not the case in FF aurora (v39) our test works and passes support on windows & osx but not on linux because arial isn't on there. So the test renders all characters in monospace.

Linux:
bs_linux_firefox_39 0 aurora

OSX:
bs_macyos_firefox_39 0 aurora

Windows:
bs_win8_firefox_39 0 aurora

@patrickkettner
Copy link
Member

Set arial as the font-family on the Linux browser before unicodeRange

On Wed, May 13, 2015, 12:00 AM Ryan Seddon notifications@github.com wrote:

But that's not the case in FF aurora (v39) our test works and passes
support on windows & osx but not on linux because arial isn't on there. So
the test renders all characters in monospace.

Linux:
[image: bs_linux_firefox_39 0 aurora]
https://cloud.githubusercontent.com/assets/143402/7603525/4dc6aa02-f978-11e4-96a2-263507fdb906.png

OSX:
[image: bs_macyos_firefox_39 0 aurora]
https://cloud.githubusercontent.com/assets/143402/7603527/4e1f25ec-f978-11e4-91b9-764f07680920.jpg

Windows:
[image: bs_win8_firefox_39 0 aurora]
https://cloud.githubusercontent.com/assets/143402/7603526/4e1e723c-f978-11e4-8739-f85fff987fb7.jpg


Reply to this email directly or view it on GitHub
#1588 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants