-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unicode-range test #1062
add unicode-range test #1062
Conversation
Sounds great! I built your fork of Modernizr but when I run the tests through the web browser it only runs 97 tests, not including the new unicode-range one. How can I try it? |
Sorry about that, I left out a key bit. |
Thanks. I can see the unicoderange property but it returns false even under I've copied your test to a JSFiddle to see it visually, but I can't tell On Sat, Oct 19, 2013 at 12:27 AM, patrick kettner
|
I've looked at http://css3test.com/ to see how they detect unicode-range support. Seems to be a very different test, based on creating a dummy element, assigning a test style and checking whether its properties match the given test value. Since I'm a n00b at browser testing, I am just reporting that this test seems to work :-) |
Man, im really sorry. This is embarrassing. That being said, after thinking about it at lunch, I was able to come up with a much simpler test that actually works. I updated this pull accordingly. RE: css3test, as it says up top
I didn't actually dig into what they are doing, but I did see it fails in all IE, so its not 100%. This test does seem to cover all browsers I can find accurately. |
Thanks so much for updating the test! Works perfectly now. On Sat, Oct 19, 2013 at 5:36 PM, patrick kettner
|
@ryanseddon @stucox - how you livin? |
LGTM. I guess the only danger would be if Arial isn’t supported and it defaults to a monospace font (or at least one which has a |
add unicode-range test
fixes #1058
This test embeds a base64'd truetype font with two characters, the
<space>
andm
specifically, specifying the unicode-range to only use the<space>
(U+002E) . It then creates four elements, two of each, one with the font and without, adds them to the DOM, and check their width. If the space changes width, and the m doesn't, then we have a winner.