Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweak in WebP test #320

Merged
merged 2 commits into from
Jul 8, 2011
Merged

Minor tweak in WebP test #320

merged 2 commits into from
Jul 8, 2011

Conversation

mathiasbynens
Copy link
Contributor

Use just false instead of function() { return false; } if the test already failed.

@mathiasbynens
Copy link
Contributor Author

Also, Christian Schaefer found a smaller data URL (saving 6 bytes, even with proper == padding!):

// 109 bytes
data:image/webp;base64,UklGRjgAAABXRUJQVlA4ICwAAAAQAgCdASoEAAQAAAcIhYWIhYSIgIIADA1gAAUAAAEAAAEAAP7%2F2fIAAAAA
// 103 bytes
data:image/webp;base64,UklGRjIAAABXRUJQVlA4ICYAAACyAgCdASoBAAEALmk0mk0iIiIiIgBoSygABc6zbAAA/v56QAAAAA==

Can this be added as well?

@paulirish
Copy link
Member

can you add the commit por favor?

@mathiasbynens
Copy link
Contributor Author

BOOM.

paulirish added a commit that referenced this pull request Jul 8, 2011
@paulirish
Merge pull request #320 from mathiasbynens/patch-2
d9e8ced 
Minor tweak in WebP test
@paulirish paulirish merged commit d9e8ced into Modernizr:master Jul 8, 2011
patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
@paulirish
Merge pull request Modernizr#320 from mathiasbynens/patch-2
7441a06 
Minor tweak in WebP test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathiasbynens @paulirish