background-size:cover test returns wrong result in FF and Opera #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulirish maybe someone could merge it? |
|
+1 |
|
Looks good. Fixes #523 too. |
paulirish
added a commit
that referenced
this pull request
May 11, 2012
background-size:cover test returns wrong result in FF and Opera
patrickkettner
pushed a commit
to patrickkettner/Modernizr
that referenced
this pull request
Feb 22, 2015
background-size:cover test returns wrong result in FF and Opera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've noticed a bug in the background-size:cover feature detection test...
The current implementation is testing for the value of the "background-size" key of the CSSStyleDeclaration object (getComputedStyle) to be equal to the string "cover". But the right name of this css property is "backgroundSize" and so the result of the test is wrong in all browsers except chrome. Here both keys "background-size" and "backgroundSize" exist and so there is no problem.
To fix this issue, simply change the key "background-size" to "backgroundSize".