Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Is this module called "Pointer and Pings!" (module) or "Pings and Pointer" (readme) #21

Closed
ScottMaclure opened this issue Apr 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ScottMaclure
Copy link
Contributor

Compare:

https://github.com/Moerill/fvtt-pointer/blob/master/module.json

"title": "PnP - Pointer and Pings!",

with https://raw.githubusercontent.com/Moerill/fvtt-pointer/master/README.md

# PnP - Pings and Pointer

I found this confusing - had to double-check I had the right module for a second!

Recommend update readme to align with published module name.

@ScottMaclure ScottMaclure added the bug Something isn't working label Apr 11, 2021
@ScottMaclure ScottMaclure changed the title [BUG] Is this module called "Pointer and Pings" (module) or "Pings and Pointer" (readme) [BUG] Is this module called "Pointer and Pings!" (module) or "Pings and Pointer" (readme) Apr 11, 2021
@ScottMaclure
Copy link
Contributor Author

Raised PR:
#22

@Moerill
Copy link
Owner

Moerill commented Apr 11, 2021

Thanks. While Pings and Pointer feels bit more natural to me its supposed to be Pointer and Pings - for legacy sake and not to try and take to much fame from the Pings module. (even though its based on the earliest versions of this module^^)

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants