-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added inspect stamp to Default loader #32
Conversation
I'm ok with this. Not in love with it though. I'm more of a minimalist though 😉 |
wellllllll, I'm not gonna force it through if I'm wrong. Maybe we can get an outside opinion? |
I just spent the last couple minutes flipping between branches, you could nearly blink and miss it. I don't feel very strongly about either version but I'd vote for adding the Inspect logo, as it's not shown anywhere else in-app. |
What bothers me more is that it appears that the colors of the 3.5" version are subtly different than the 4" version. |
Iirc, according to the HIG the default images should reflect the normal UI, but in a blank state. So it should not show a (big) UI element that’s never there under normal circumstances. And especially considering that the image might only be shown for a short while (as is the case pointed out by @mattsgarrison), it makes the app seem less polished imo. So I’d say no. |
|
@alloy agreed on the documentation... but it's obviously one of those rules no one listens to. Look to twitter, and google drive, and hangouts etc. They often show their brand in the middle while the app loads. I'm fine flushing the style out, but not because of apple doc rules that are never enforced. I want your user experience opinion :) |
With regards to UX, I agree with the guidelines, in this case :) The image is gone too fast for me to be able to make it out and read the title. (Note, however, that I am on a 5s.) |
gonna kill this :) Survey says no go. ty everyone for feedback :) |
Proposed default loader for issue #30