Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point number allowed for molecular charge but not molecular multiplicity #317

Open
awvwgk opened this issue Aug 3, 2023 · 1 comment · May be fixed by #318 or #350
Open

Floating point number allowed for molecular charge but not molecular multiplicity #317

awvwgk opened this issue Aug 3, 2023 · 1 comment · May be fixed by #318 or #350

Comments

@awvwgk
Copy link
Contributor

awvwgk commented Aug 3, 2023

Describe the bug

QCElemental allows floating point numbers for molecular charges, however when computing the spin with the fractional electron there is no way to represent the molecular multiplicity with just an integer.

To Reproduce

import qcelemental as qcel
mol = qcel.models.Molecule(
    geometry=[0.0, 0.0, 0.5, 0.0, 0.0, -0.5],
    symbols=["H", "He"],
    molecular_charge=0.5,
    molecular_multiplicity=1.5,  # not possible
)

Expected behavior

Consistent behavior for specifying molecular charge and molecular multiplicity.

Additional context

@awvwgk awvwgk linked a pull request Aug 3, 2023 that will close this issue
2 tasks
@loriab
Copy link
Collaborator

loriab commented Aug 8, 2023

I'll make sure to bring this up to @bennybp to see if the database is ready for a type change.

@loriab loriab linked a pull request Sep 18, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants