Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbomole support #157

Closed
eljost opened this issue Sep 23, 2019 · 3 comments
Closed

Turbomole support #157

eljost opened this issue Sep 23, 2019 · 3 comments

Comments

@eljost
Copy link
Contributor

eljost commented Sep 23, 2019

Hi,
a request for a TURBOMOLE interface came up in this geomeTRIC issue.
As I already developed a TM-wrapper for my own code I'd be willing to work on an implementation in QCEngine.
Right now the way my wrapper works is quite incompatible to QCEngine I imagine... In my code you have to prepare a control-file beforehand (through the TM-utility define) that gets passed to the wrapper class. All contents from this directory get copied to a temporary directory, from where the calculation is actually run.

What is needed for QCEngine is probably a wrapper for define?!
What would you consider to the minimal feature-set that should be implemented?

Best regards
Johannes

@dgasmith
Copy link
Collaborator

TURBOMOLE integration would be fantastic and something that has been asked after before.

A minimal viable block for a compute is a SCF energy/gradient return. This would satisfy the geomeTRIC requirements as well. A lot of the technology behind your wrapper can be reused I believe. The first step would be to join Slack (on the README of this repo) so that we can chat a bit about possible solutions and integrations. If TURBOMOLE does not support some sort of binary output it would like be the case that the wrapper would look similar to NWChem.

Overall QCEngine would like to support projects like pysisyphus so that everyone does not have to rewrite these wrappers. We look forward to working with you on this.

@mkrompiec
Copy link

@eljost: great that you are happy to do this. I think a wrapper for define would be a good idea, as long as examples of "typical" use cases are given. One more thing: pysiphus is released under GPL, would you be happy to release the code under a more permissive license?

@dgasmith
Copy link
Collaborator

dgasmith commented Nov 8, 2019

@mkrompiec I believe the Turbomole wrapper is now in here under BSD-3C.

Thanks again @eljost for this! We look forward to running Turbomole :)

@dgasmith dgasmith closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants