Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC support for high-end M2 (Pro/Max/Ultra) systems #1404

Merged
merged 1 commit into from
Aug 14, 2023
Merged

DDC support for high-end M2 (Pro/Max/Ultra) systems #1404

merged 1 commit into from
Aug 14, 2023

Conversation

waydabber
Copy link
Member

Added DDC support for high-end M2 (Pro/Max/Ultra) systems using displays connected via USB-C/ThunderBolt/DisplayPort and HDMI.

(note: somebody with an M2 Pro/Max/Ultra Mac should test it, I am still on M1 :))

…ays connected via USB-C/ThunderBolt/DisplayPort and HDMI.
@JerryZhangZZY
Copy link

Could you post a compiled .dmg file so that I can test it?

@waydabber
Copy link
Member Author

waydabber commented Jul 31, 2023

Sure. This build is unsigned and not notarized so you'll need to manually allow it to run under Security&Privacy. Let me know if you did try it so I can delete this.

[Removed]

@JerryZhangZZY
Copy link

JerryZhangZZY commented Aug 1, 2023

Sure. This build is unsigned and not notarized so you'll need to manually allow it to run under Security&Privacy. Let me know if you did try it so I can delete this.

[Removed]

DDC works perfectly on M2 Pro, nicely done mate!

@waydabber
Copy link
Member Author

Great! Thanks for the feedback!

waydabber added a commit to waydabber/AppleSiliconDDC that referenced this pull request Aug 2, 2023
Updated to work on M2 Pro/Max/Ultra systems. Same as version added in this PR: MonitorControl/MonitorControl#1404
@nic
Copy link

nic commented Aug 6, 2023

Amazing! DDC works sweetly fine on M2 Ultra. Awesome job, dude! 🤩

@devantler
Copy link

devantler commented Aug 7, 2023

@waydabber Awesome work! 😃 Sadly, I was not able to make this work. The volume is not affected when I change the volume slider with the Apple keys or the slider in MonitorControl.

image

  • LG C2 connected on HDMI_2 (can this affect the logic?)
  • The build has been allowed under Security&Policy>Accessiblity

Can it be related to running Sonoma?

@waydabber
Copy link
Member Author

@waydabber Awesome work! 😃 Sadly, I was not able to make this work. The volume is not affected when I change the volume slider with the Apple keys or the slider in MonitorControl.

image

  • LG C2 connected on HDMI_2 (can this affect the logic?)
  • The build has been allowed under Security&Policy>Accessiblity

Can it be related to running Sonoma?

Sadly the LG C2 (as most TVs) does not support DDC. :(

@alexforster
Copy link

Worked on my new MBP Mac14,9 driving two LG 27UN880-B monitors.

@devantler
Copy link

Sadly the LG C2 (as most TVs) does not support DDC. :(

Ah damn. Back to proxy-audio-device for me then 🙂

Copy link
Member

@the0neyouseek the0neyouseek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 LGTM ! Thank you so much for the PR, everything looks good as far as I can see !

@waydabber
Copy link
Member Author

Thanks @the0neyouseek ! :)

@pakal-org
Copy link

Can we expect a release soon ?

Thanks

@waydabber waydabber merged commit c5c8bf1 into main Aug 14, 2023
2 checks passed
@waydabber waydabber deleted the update branch August 14, 2023 16:08
@waydabber
Copy link
Member Author

Can we expect a release soon ?

Thanks

I am not sure, I can't sign a build for release, it depends on the team. You can of course build a version using XCode anytime.

@pakal-org
Copy link

I thought that project was dead...
I can wait a little more :)

@waydabber
Copy link
Member Author

@pakal-org, the project is not dead, just in a bit slow-to-respond mode...

Note: if you don't want to build a release yourself, you can try BetterDisplay meanwhile as it has DDC brightness control for the M2 Pro for free - try https://github.com/waydabber/BetterDisplay/releases/tag/v2.0.6-pre-release

@pakal-org
Copy link

I know about your product :)
I like the "lightness" of Monitor Control ...

@waydabber
Copy link
Member Author

Yes, I can understand that. :)

@dellhem
Copy link

dellhem commented Aug 24, 2023

What a flex! Fixing the competition's issues 😆 Great work, @waydabber 😘

@cgull
Copy link

cgull commented Aug 25, 2023

Thanks, @waydabber -- this works fine for me on a 14" M2 MBP Mac14,5 and two LG LS27A800U monitors on USB-C cables, after building e038b89.

Maintainers, what blocks generating a new release?

@JoniVR
Copy link
Member

JoniVR commented Aug 25, 2023

We'll do a new release with this fix soon.

@kaeferfreund
Copy link
Contributor

I have compiled it on my own and it works like a charm, very stable so far :)

@lestmak
Copy link

lestmak commented Sep 11, 2023

On a Mac Mini M2 Pro with an LG UltraWide Monitor 38WN95C-W. Working beautifully and perfectly. Thanks for this!

@frunika
Copy link

frunika commented Sep 12, 2023

Work's perfect. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet