[PORT] Better Ghost Selection #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
force-pushed
the
hahaha-im-fucking-unstoppable-im-amazing-im-the-goddess-of-coding-here
branch
2 times, most recently
from
7b10c95
to
2a3a03b
Compare
Absolucy
force-pushed
the
hahaha-im-fucking-unstoppable-im-amazing-im-the-goddess-of-coding-here
branch
from
2a3a03b
to
3644750
Compare
This was referenced Mar 6, 2024
Closed
Closed
Absolucy
force-pushed
the
hahaha-im-fucking-unstoppable-im-amazing-im-the-goddess-of-coding-here
branch
from
3644750
to
2d1daba
Compare
|
Seems to be ready, haven't seen any issues so far. |
This was referenced Mar 7, 2024
Closed
Closed
This was referenced Mar 11, 2024
…ject Zomboid) (tgstation#81833) ## About The Pull Request Changes the easing and slows down status alert animations. https://github.com/tgstation/tgstation/assets/51863163/3e5a7789-5c38-446d-9c9c-197fe1a320d2 ## Why It's Good For The Game I was playing Project Zomboid a while back, a game which has a similar alert system that we have (in that they stack up on the right side of the screen), and I wondered "why don't our screen alerts animate, why do they just pop up?" And the answer to that is they do animate. But their animation is... 0.25 seconds long. Which is at worst, not noticeable, and at best, glitchy looking. So I just... changed the easing and slowed it down a bit. Now, when an alert enters the screen, it does a little bounce. I believe this will make screen alerts a bit less unpleasant to look at and a bit more noticeable for newer players. This also has a neat effect (as demonstrated in the video) of making "updating" alerts stand out a bit more. Before when something like "wounded" would update, it would just appear to be glitching out of the right side of the screen. Now it wiggles to show you it's updated. And of course, this can be played with in the future. If we wanted to go full Zomboid style we can scale the power of the bounce down for less important alerts / scale it up for more pertinent alerts. Or bounce things which are actively a hazard like pressure or fire or temperature. Also, we can give alerts a bit more of a static order. In the demo video it swaps around which is kinda ugly, but we can fix that. ## Changelog :cl: Melbert add: The animation that plays when an alert pops up on your screen is different. /:cl:
This was referenced Mar 15, 2024
This was referenced Mar 17, 2024
This was referenced Mar 17, 2024
Closed
Closed
Absolucy
deleted the
hahaha-im-fucking-unstoppable-im-amazing-im-the-goddess-of-coding-here
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation#80283
Currently blocked by #1386fixed!Why It's Good For The Game
Way easier to see what role is available, you get a nice pic of the role and get it's name in big text, you can cancel "never for this round", and you can cancel signing up for a role before the timer is up
Screenshots
Changelog
🆑
refactor: Ghost roles now offer ghosts a clickable poll button. Ghosts can select a role, deselect it, alt-click it for "Never For This Round", can cancel "Never", can see the countdown, and can see how many other people are signed up for the role poll.
fix: Admins can now properly force events to fire.
/:cl: