Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereal Visual + Mechanical Overhaul. #1966

Merged
merged 28 commits into from
Jun 6, 2024

Conversation

KittyNoodle
Copy link

@KittyNoodle KittyNoodle commented May 22, 2024

Credit Section:

@zestybastard for the ethereal horn/tail sprites seen in shiptest-ss13/Shiptest#1501
@aberrantQuereist for the new ethereal body sprites and tail sprite changes

About The Pull Request

Features of this project.

  • New Sprites
  • Eye Sprites
  • Horns
  • Tails
  • Blood Charge
  • Bugfixes

Features for part 2

  • Starbound-style Brands
  • Full Color Selection
  • Multitool Color Selection/Adjustment

Why It's Good For The Game

More visual variety for ethereal players!!!

Changelog

🆑 AberrantQuerist Noodlecat Zestybastard
add: Ethereals now use their blood as charge, and their stomach as a method of recharge, instead of the stomach occupying the entire charge mechanic.
add: Ethereal Eyes
add: Ethereal Horns
add: Ethereal Tails
fix: Ethereal meat no longer tastes like meat, as they are crystalline beings, and now tastes like glass(mmm crunchy)
fix: Ethereals now correctly turn grey after dying.
image: New Sprites for ethereals
/:cl:

KittyNoodle and others added 12 commits May 7, 2024 23:35
…t organ code and its actually poisoning my mind. i have discovered something that could be the possible trigger for the admin spawn glitch and also a fix, that using a ressurection wand on the victim can fix it, but only if the victim is an ethereal. may archous save us all
@thgvr
Copy link

thgvr commented May 27, 2024

You didn't ask for permission to port these art assets and didn't credit anyone, what is up with that?

@Imaginos16
Copy link

Huh, that's weird, doesn't that come from shiptest? Golly gee, where's the fucking credit?

@Taomayo
Copy link

Taomayo commented May 27, 2024

Credit the content creators for this on shiptest

@dwasint
Copy link
Collaborator

dwasint commented May 27, 2024

Didn't know these came from shiptest, looked for the pr which is: shiptest-ss13/Shiptest#1501 Ask requested please ask for sprite permission from the original artist, for the time being it will be un-tm'd

@aberrantQuesrist
Copy link

Alright, so I've been alerted to some massive miscommunication in regards to this PR. As someone doing the sprite recreations for bodies/tails here I'd like to publicly apologize for this mistake. The onus is on me, I should not have assumed any permission was already given. I'm going to make sure all the channels are properly followed from this point forward.

@KittyNoodle
Copy link
Author

As the person other half of the people responsible for the port(it was a joint project between me and aberra) i was NOT made aware that permissions had not been already asked for, and had believed that she had gotten permission before handing over the sprites for me to get into the game.

@KittyNoodle
Copy link
Author

As for why credit was not in the pr description, the pr description is very much not in its finalized state(hense the draft status) and i had not gotten around to getting down half the information as to what this actually adds other than a checklist. This will be rectified shortly.

@thgvr
Copy link

thgvr commented May 27, 2024

All good. We've had issues in the past of random forks/servers just taking some of our art without crediting whatsoever.

As for the permission bit, it's more out of a desire to see other places carve out their own designs and be unique in their own regard. In the end, I can't stop you from taking anything but I feel it will degrade the quality and direction of your development, in a similar manner that taking/porting random out of place assets would make Shiptest look worse visually.

@LemonInTheDark
Copy link

LemonInTheDark commented May 27, 2024

for the sake of full clarity

you already have permission to use any asset licensed under CC-BY-SA (assuming the author is credited and the license is retained)
that's what creative commons is, it IS permission, it can't be revoked. thgvr was bein maybe a bit overzealous is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants