Ranching: A new Horizon #2017
Ranching: A new Horizon #2017
Conversation
|
|
||
| mobs_to_pick += return_donator_mobs() | ||
|
|
||
| if(!patreon.has_access(ACCESS_ASSISTANT_RANK) && !is_admin(src) && !length(mobs_to_pick)) |
There was a problem hiding this comment.
| if(!patreon.has_access(ACCESS_ASSISTANT_RANK) && !is_admin(src) && !length(mobs_to_pick)) | |
| if(!length(mobs_to_pick || (!patreon.has_access(ACCESS_ASSISTANT_RANK) && !is_admin(src)))) |
im pretty sure this means the first 2 checks are useless
There was a problem hiding this comment.
These do the exact same thing.
| var/list/spawned_mobs = list() | ||
| var/list/deletors = list() | ||
| for(var/mob/living/basic/basic as anything in mobs_to_pick) | ||
| var/mob/living/basic/created = new basic() |
There was a problem hiding this comment.
I suggest using static vars to avoid spawning in the mobs every time
| if(!choice) | ||
| spawned_mobs = null | ||
| QDEL_LIST(deletors) | ||
| return pick(basic_list) |
There was a problem hiding this comment.
this makes it so you cant cancel out of becoming a mob
|
|
||
| mob.mind.transfer_to(created_mob, TRUE) | ||
|
|
||
| if(patreon.has_access(ACCESS_NUKIE_RANK) || is_admin(src)) |
There was a problem hiding this comment.
not a huge fan of this, seems like it could lead to issues
There was a problem hiding this comment.
This was requested in the design doc I was given so its not being removed
| if(!mob.mind) | ||
| mob.mind = new /datum/mind(key) | ||
|
|
||
| mob.mind.transfer_to(created_mob, TRUE) |
There was a problem hiding this comment.
if this is taking from an observer then this needs to do a key transfer instead as this keeps antag status from previous lives
There was a problem hiding this comment.
Also part of the design doc from what I can see. This prevents you from ghost crittering dying, then your main body getting ressed and losing antag status
|
|
||
| if(ghost.client.ghost_critter_cooldown > world.time) | ||
| return | ||
|
|
There was a problem hiding this comment.
Could use a confirmation prompt here, you can genuienly be a new player, click on the structure to examine it and without a warning accidentally become a critter
Also maybe a description would be good
About The Pull Request
ports horns from: NovaSector/NovaSector#1188, if anyone knows the pr link to the og pr please lmk so i can credit that
Why It's Good For The Game
Changelog
🆑
fix: chicks getting happiness reset
add: chugging, drag a cup onto you and start chugging
change: a rooster is now required in order for chickens to lay fertile eggs
/:cl: