[PORT] Saves profiler snapshots every 5 minutes #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request As the title says. Each saved snapshot will be named - `profiler-[TIME IN SECONDS].json` - `sendmaps-[TIME IN SECONDS].json` For example, `profiler-0.json`, `profiler-300.json`, `profiler-600.json` would correspond to a profile at the start of the round, a profile 300 seconds into a round and a profile 600 seconds into a round. The timings depend on world.time, so it's probably not a good idea to rely on these timings to stay consistent. ## Why It's Good For The Game Allows us to track performance of procs over time. Could allow us to spot any sort of anomalies or performance sinks. CC: @MrStonedOne @bobbah @LemonInTheDark --------- Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
This was referenced Jun 11, 2024
Closed
Open
Open
This was referenced Jun 14, 2024
This was referenced Jun 15, 2024
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of tgstation#83467
As the title says. Each saved snapshot will be named
profiler-[TIME IN SECONDS].jsonsendmaps-[TIME IN SECONDS].jsonFor example,
profiler-0.json,profiler-300.json,profiler-600.jsonwould correspond to a profile at the start of the round, a profile 300 seconds into a round and a profile 600 seconds into a round.The timings depend on world.time, so it's probably not a good idea to rely on these timings to stay consistent.
Why It's Good For The Game
Allows us to track performance of procs over time. Could allow us to spot any sort of anomalies or performance sinks.