Updated to the latest version of StbSharp #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
|
build succeed |
|
@dellis1972 Could this PR indirectly fix #6093 ? |
|
I don't think so.
…On 18 January 2018 at 17:22, Vicente Penades ***@***.***> wrote:
@dellis1972 <https://github.com/dellis1972> Could this PR indirectly fix
#6093 <#6093> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6131 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxeedRpNt53KMO7te0rGOl3q33ZixDaks5tL33ZgaJpZM4RU5So>
.
|
|
As far as I know, StbSharp is only used in the Texture2D.FromStream. And only in the DesktopGL version of MG, as #6008 hadn't been merged yet. |
nkast
pushed a commit
to nkast/MonoGame
that referenced
this pull request
Jan 28, 2018
nkast
pushed a commit
to nkast/MonoGame
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates MG's version of StbSharp to the latest one.
Hopefully it would fix #6114 with loading textures from multiple threads. I've replaced Dictionary with ConcurrentDictionary and updated my testing framework, so about 800 textures were simultaneously processed from 10 different threads. There were no problems.
Also latest Stb can write JPGs. So TinyJpegSharp had been removed.