Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGCB improvements #6492

Merged
merged 2 commits into from Aug 9, 2019
Merged

MGCB improvements #6492

merged 2 commits into from Aug 9, 2019

Conversation

Jjagg
Copy link
Contributor

@Jjagg Jjagg commented Oct 8, 2018 •
edited

  • Response files can be run from any working directory (fixes mgcb broken relative paths #4190)
  • Adds support for nested response files
    • In the Pipeline Tool this is limited to response files in the same directory as the opened project
      because we don't have a way to display the content otherwise.
  • Fix a bug in parsing --define
  • Improve MGCB parsing code readability
    • defines can just be stored in a Dictionary
    • Replace old style Tuple with struct
  • Allow $set <name> and $if <name> without values (stored as empty string).

@Jjagg Jjagg assigned harry-cpp and unassigned harry-cpp Oct 8, 2018
@Jjagg Jjagg requested a review from harry-cpp October 8, 2018 15:43
@Jjagg Jjagg force-pushed the mgcb-wd branch 2 times, most recently from 52ab6db to b1d2072 Compare October 9, 2018 12:26
@Jjagg
Copy link
Contributor Author

Jjagg commented Aug 9, 2019

@cra0zy This is still good to go as far as I'm concerned.

@harry-cpp harry-cpp merged commit c1fef9f into MonoGame:develop Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry-cpp harry-cpp Awaiting requested review from harry-cpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mgcb broken relative paths
2 participants
@Jjagg @harry-cpp