Add support for MaximizeWindow in DesktopGL platforms (uses SDL_MaximizeWindow)

[HS-Dave]

No description provided.

[mrhelmut]

If we're adding a method to the public API, we should implement it for all platforms to not mislead users with platform-specific public APIs.

[HS-Dave]

If we're adding a method to the public API, we should implement it for all platforms to not mislead users with platform-specific public APIs.

I agree in principle, although the work to add to other platforms is a margin higher - but there is already precedent for platform only features in this class such as IsBordless to hide the border which docs specify "Currently only supported on the WindowsDX and DesktopGL platforms." and FileDrop which obviously only works on desktop platforms.

[mrhelmut]

Yes, but we should avoid making an exception to be the rule if we want the framework to be more accessible. At minimum, I'd like to suggest that we have the public API available for all platforms, and per-platform throwing NotImpletedException than having no public API at all.

[HS-Dave]

that seems an insane amount of external work to do for what is currently 18 lines in API and 1 call in implementation. I still strongly disagree that adding a method like this that is only available for specific platforms waters down the API in any meaningful way (and no more than throwing a not implemented exception) but I would rather implement the feature for whichever platforms support it than over engineer an external window manager. All we are trying to do here is maximise an already existing window without having to manually fetch the screen dimensions and set them ourselves :)

[mrhelmut]

I still strongly disagree that adding a method like this that is only available for specific platforms waters down the API in any meaningful way (and no more than throwing a not implemented exception)

I should have started with that I guess. We have the plan to unify the public API and cleanse it of platform-specific #if. For that project to happen, we need the public API to be the same for all platforms.
We also believe that it is a better experience to have a code that compiles as-is for all platform (and proceed silently) and that doesn't oblige multi-platform projects to have #if too.

[HS-Dave]

I still strongly disagree that adding a method like this that is only available for specific platforms waters down the API in any meaningful way (and no more than throwing a not implemented exception)

I should have started with that I guess. We have the plan to unify the public API and cleanse it of platform-specific #if. For that project to happen, we need the public API to be the same for all platforms. We also believe that it is a better experience to have a code that compiles as-is for all platform (and proceed silently) and that doesn't oblige multi-platform projects to have #if too.

in context of your plan this now makes a lot more sense - I will see what I can do to support the non SDL platforms with this same feature as I feel its a pretty useful base feature, leave it with me a couple of evenings