Respect setting Window.Title in Game1 constructor
#8052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks @AristurtleDev , merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting the
Window.Titlein theGame1constructor, the title set is ignored. This is because theSDLGameWindow.CreateWindow()method explicitly chooses to useAssemblyHelper.GetDefaultWindowTItle(). During this time, theSDLGameWindow.Titleproperty contains the correct window title that is set during theGame1constructor, but ignores this.This PR resolves this issue by explicitly checking if
SDLGameWindow.Titleisnull, and if so, then it will useAssemblyHelper.GetDefaultWindowTitle(), otherwise it will use the title that was set by the user in theGame1constructor as expected.Reference:
An issue was opened previously at Issue #7913
Note:
This PR is also related to PR #8051, however I created two separate PRs as each focuses on a separate issue to fix.