Issue #8084: DesktopGL GraphicsDevice.ScissorRectangle Fix #8284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix to this problem was testing to see if the ScissorRectangle was enabled and resizing it whenever the viewport was resized. This was not done by default for DesktopGL as far as I could tell.
SimonDarksideJ
requested changes
May 1, 2024
| _game.GraphicsDevice.PresentationParameters.BackBufferWidth = width; | ||
| _game.GraphicsDevice.PresentationParameters.BackBufferHeight = height; | ||
| _game.GraphicsDevice.Viewport = new Viewport(0, 0, width, height); | ||
|
|
||
| if (_game.GraphicsDevice.RasterizerState.ScissorTestEnable && prevScissorRect == prevViewport.Bounds) |
There was a problem hiding this comment.
A question, if the check is only on the PREVIOUS viewport bounds (and not the updated version in lines 306-308), then why is this change AFTER the viewport update?
- If the Scissor check is based on the PREVIOUS viewport bounds, then this condition should be moved to line 305.
- If the Scissor check is AFTER the update to the viewport bounds, should this not be validating against the NEW and not the previous bounds?
There was a problem hiding this comment.
After looking over it, it should have been at line 305 as you stated. Just pushed an update.
Resolving Simon's comment with regards to the placement of the conditional.
SimonDarksideJ
approved these changes
May 2, 2024
dellis1972
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issue #8084.
Updates ClientResize function in order to update the ScissorRectangle when the viewport is resized. This change mimics the behavior found on other platforms such as WindowsDX.