Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to update metadata JSON CIDs and final CIDs #19

Closed
Montspy opened this issue Mar 18, 2022 · 2 comments
Closed

Add option to update metadata JSON CIDs and final CIDs #19

Montspy opened this issue Mar 18, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Montspy
Copy link
Owner

Montspy commented Mar 18, 2022

Users might want to edit images and/or non-critical metadata after generation.
That means CIDs can become stale and should be updated to the new file contents.
I propose we add some option(s) to metadata.py to update the image and animation_url CIDs as well as the final metadata CIDs.
It would run the normal flow but read JSON, update the CIDs and write back.

@Montspy
Copy link
Owner Author

Montspy commented Mar 22, 2022

This feature is implemented in #28

@Montspy Montspy self-assigned this Mar 27, 2022
@Montspy
Copy link
Owner Author

Montspy commented Mar 27, 2022

Merged. Closing.

@Montspy Montspy closed this as completed Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant