Add option to configure sending hostname #28
Conversation
|
Could you please add some documentation to the README as well |
|
You'll also need to add host as a configurable field, and then pass it into the new instance of GelfConverter at https://github.com/Moocar/logback-gelf/blob/master/src/main/java/me/moocar/logbackgelf/GelfLayout.java#L149 |
|
Better? :) Let me know if it needs more work. |
|
Any update on this? Do I need to make more changes, or is it OK to merge now? |
| @@ -69,6 +70,7 @@ will be the name of the thread. Defaults to false; | |||
| changed from 0.9.5 -> 0.9.6. Allowed values = 0.9.5 and 0.9.6. Defaults to "0.9.6" | |||
| * **chunkThreshold**: The maximum number of bytes allowed by the payload before the message should be chunked into | |||
| smaller packets. Defaults to 1000 | |||
| * **sendinghost** The hostname of the sending host. Defaults to getLocalHostName() | |||
|
Hey, I've been on holiday all week. Sorry for not getting back sooner. If you can address that last comment I made, then I'll be happy to merge |
|
No problem. I just wanted to make sure that it didn't get forgotten. I just fixed the readme. |
Add option to configure sending hostname
|
merged. Thanks for the new feature :) |
|
Excellent, thanks. Sorry to move straight on to the next request, do you have a timeline for the next release? It would be great to get this in the repositories. |
|
I'll let it sit for a few days. Are you using this in production? Would be On Tue, Dec 17, 2013 at 8:19 PM, Daniel Scott notifications@github.comwrote:
|
|
I have it running on my local system, but I don't have it on any of our prod/uat stacks yet. I need to get an equivalent patch into dropwizard-gelf (https://github.com/gini/dropwizard-gelf) before I can move on... :) |
|
This is part of release 0.10p2 which should be up on maven central in a couple of hours |
Let me know what you think. :)