Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option "Reset Application" to Moonshine's settings #27

Closed
piotrzarzycki21 opened this issue Sep 26, 2017 · 8 comments
Closed

Add option "Reset Application" to Moonshine's settings #27

piotrzarzycki21 opened this issue Sep 26, 2017 · 8 comments
Assignees
Milestone

Comments

@piotrzarzycki21
Copy link
Collaborator

In order to get back application to the state from the first clean installation we should add option "Reset Application" in the settings.

Reset:

  • Once user choose option "Reset Application" we need to have clean information message what will happen
  • Moonshine will be restarted
@rat-moonshine rat-moonshine self-assigned this Oct 17, 2017
@rat-moonshine rat-moonshine moved this from To Do to In Progress in Moonshine-IDE - Features Oct 17, 2017
rat-moonshine added a commit that referenced this issue Oct 17, 2017
@piotrzarzycki21 piotrzarzycki21 added this to the v1.7.0 milestone Oct 17, 2017
rat-moonshine added a commit that referenced this issue Oct 18, 2017
@rat-moonshine
Copy link
Collaborator

Some things yet to look into:

  • Upon cleaning settings, bottom SDK notification yellow patch is not showing (display not updating)
  • Needs to think about how to handle Template settings reset

@rat-moonshine
Copy link
Collaborator

  • Upon resetting, bottom SDK notification strap now showing properly
  • After resetting startup prompt sequences re-initiated - SDK, Java etc.

@rat-moonshine
Copy link
Collaborator

  • In Windows, everything shall reset including saved SDK list
  • In Mac, except the bundled SDKs (~/Downloads/MoonshineSDKs) all other SDK will be removed from the list
  • Per existing logic in Mac, one SDK will always set to default if any bundled SDK is present - after Clear (Moonshine > Settings > Default SDK) or Reset (Moonshine > Settings > General) happen

rat-moonshine added a commit that referenced this issue Oct 23, 2017
~/Downloads/MoonshineSDKs/Ant in case of OSX (reference #27)
@JoelProminic
Copy link
Contributor

I ran some tests for resetting the template data.

I added a comment line to each of the file templates, and then reset the settings. My changes were cleared.

I added a new file template with "Create new". After I reset the settings, this was cleared. (NOTE: I could not change the new file name, and I'm not sure how this would integrate with the current UI anyway. We may need to revisit this feature at some point).

For the project templates, I added a comment to the main file for each of the projects. I verified that my changes were reverted after running "Reset Everything".

@rat-moonshine
Copy link
Collaborator

I could not change the new file name, and I'm not sure how this would integrate with the current UI anyway. We may need to revisit this feature at some point

I think we could have a new issue reported on this, as an enhancement.

@piotrzarzycki21
Copy link
Collaborator Author

@rat-moonshine can we raise the new issue for that one and close #27 ?

@rat-moonshine
Copy link
Collaborator

That is how we agreed in fact in our last discussion with Joel. So yes, we can proceed that way, @piotrzarzycki21 .

@piotrzarzycki21
Copy link
Collaborator Author

Issue mentioned by @JoelProminic has been extracted #62

@rat-moonshine rat-moonshine moved this from In Progress to Done in Moonshine-IDE - Features Nov 7, 2017
@piotrzarzycki21 piotrzarzycki21 modified the milestones: v1.7.0, v1.6.1 Nov 10, 2017
@piotrzarzycki21 piotrzarzycki21 moved this from Done to Done #1.6.1 in Moonshine-IDE - Features Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants