Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant Home is Reset When Starting Moonshine #53

Closed
JoelProminic opened this issue Oct 23, 2017 · 2 comments
Closed

Ant Home is Reset When Starting Moonshine #53

JoelProminic opened this issue Oct 23, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@JoelProminic
Copy link
Contributor

While testing #27, I noticed a problem with the behavior for the Ant Home setting.

  1. Open Moonshine
  2. Open Settings > Ant Build Setup
  3. Change Ant Home to a different directory (in my case, I used ~/Downloads/MoonshineSDKs/ant-1.9.7). (On a side note, the filechooser always opens to ~/Desktop for Ant Home)
  4. Save the change
  5. Restart Moonshine
  6. Open Settings > Ant Build Setup
  7. BUG: the value has been reset to the default (~/Downloads/MoonshineSDKs/Ant/apache-ant-1.10.1

So, if the user tries to use a different copy of Ant (for example, a newer version), then they would have to set the home location again each time they opened Moonshine.

I get the same results if I use a directory outside of MoonshineSDKs: /Users/joelanderson/.sdkman/candidates/ant/1.9.7

@rat-moonshine rat-moonshine self-assigned this Oct 24, 2017
@rat-moonshine
Copy link
Collaborator

I see the existing logic against setting Ant home path was if Ant SDK found inside the folder that creates by App Store Helper (~/Downloads/MoonshineSDKs/Ant), then automatically set the path with the same. This by dismissing any existing path as I see in the logic.

I'm going to make requisite changes per current expectation.

rat-moonshine added a commit that referenced this issue Oct 24, 2017
rat-moonshine added a commit that referenced this issue Oct 24, 2017
@rat-moonshine rat-moonshine moved this from In Progress to Done in Moonshine-IDE - Bug Fixing Oct 24, 2017
@piotrzarzycki21 piotrzarzycki21 added this to the v1.7.0 milestone Oct 24, 2017
@piotrzarzycki21 piotrzarzycki21 modified the milestones: v1.7.0, v1.6.1 Nov 10, 2017
@JoelProminic
Copy link
Contributor Author

I tested this again in preparation for the 1.6.1 release. I confirmed these cases:

  • Setting path to different directory under ~/Downloads/MoonshineSDKs
  • Setting path to other directory (~/SDKs/...)
  • Resetting the value.

rat-moonshine added a commit that referenced this issue Nov 10, 2021
- Updated terminal path to work on > HighSierra

(#55, #53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants