-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Associations Broken on Windows #800
Comments
- Downgrading SKD to 32 to test file-association issue (#800)
Unfortunately, installing stable v3.0.0 on my Windows system didn't shown me any file-association either. I tried to build current branch build using Adobe AIR 30.0, that also didn't shown me any file-association sign. ;/ |
I did some investigation for this with @rat-moonshine today. I see that the commands for extensions are assoc and ftype.
By my understanding, these mappings are defined by registry keys. I see the "file type" registry entires, but not the "ProgID"
After some testing, we confirmed that the registry keys are not updating when Moonshine is installed. With a fresh Windows machine, no Moonshine registry keys are added. Since we are using NSIS for the installer now, we probably need to have it manage the registry keys as well. The API is here. |
File association on Windows now fixed with NSIS integration. This fix applied into master. Please, check. |
@rat-moonshine Your changes may have been lost somehow due to some weird push from Bing to master. I have applied back what was on master before, but it looks like there is missing following commit e532d4f - You may have to apply it again. |
I have re-committed my changes, should be good for a test now. |
I confirmed that the registry keys were updated:
I confirmed that the files opened automatically with Moonshine. I'm a little concerned about setting Moonshine as the default for some common files (like .html). However, in my tests I saw that .html files still opened with Firefox by default, so this seems to be fine. However, I did notice that registry keys were not cleaned up when Moonshine was uninstalled. For example, this means that .mxml files were still considered "Moonshine.MXML.File" even though Moonshine was no longer available. Does NSIS have an API for this as well? |
It probably does, I just didn't removed the association during an uninstallation. I shall add the cleanup, if it's helpful to some cases. |
I have added the unregistering steps for the Moonshine file-association during an uninstall on Windows. Please, check. |
Recently @JoelProminic reported that even after the un-installation and file-type-disassociation, command-line still reports leftover descriptions in registry:
Those leftover descriptions now being removes during an un-installation and should return no value when the command run. |
I confirmed that all the extension-related Moonshine registry keys were cleaned up when I uninstalled Moonshine. |
@JoelProminic recently reported that double-clicking a project file from Explorer/Finder do focus Moonshine but nothing opens. I also confirm the similar behavior for known files. I have now commit a fix, a new build should be ready for a test. |
Earlier freeze scenario is now fixed with newest build. Please, check. |
I tested this today with latest build, and following are my test matrix. @JoelProminic please add, if any other point you may think. Else, I think we can close it.
|
I have tested this today with my Windows 10 Home machine. I did test with Flex, Royale and JavaGradleProjects everything works fine. I'm closing issue - let's reopen it or move to another milestone in case of problems. |
While testing #799, we noticed that Windows did not give the option to open .*proj or other files with Moonshine.
I can still open the files with Moonshine if I manually select Moonshine in the file chooser.
I installed the latest stable build (3.0.0), and found that it works fine. So, it seems this bug was not introduced with the NSIS installer change.
Could this bug be caused by the switch to Harman AIR (#773)?
The text was updated successfully, but these errors were encountered: