Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Table::addRecord toTable::insertRecord #6

Open
jwillp opened this issue Nov 14, 2019 · 0 comments
Open

Rename Table::addRecord toTable::insertRecord #6

jwillp opened this issue Nov 14, 2019 · 0 comments
Labels
breaking-change Code change that are considered breaking changes enhancement New feature or request good first issue Good for newcomers
Milestone
Release 1.0

Comments

@jwillp
Copy link
Contributor

jwillp commented Nov 14, 2019

Rename that function:

YDB/src/Table.php

Line 311 in 33f9766

public function addRecord(RecordInterface $record): void

For improved terminology

This is a breaking change.
@jwillp jwillp added good first issue Good for newcomers breaking-change Code change that are considered breaking changes enhancement New feature or request labels Nov 14, 2019
@jwillp jwillp added this to the Release 1.0 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Code change that are considered breaking changes enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Release 1.0
Development

No branches or pull requests
1 participant
@jwillp