Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bug when destroy assignments #200

Merged
merged 1 commit into from
Feb 23, 2019
Merged

Handle bug when destroy assignments #200

merged 1 commit into from
Feb 23, 2019

Conversation

bokusunny
Copy link
Member

概要

targetDomがnullの時にバグが発生して画面がまっさらになってしまうので、根本的解決とはいきませんが、次善策として、エラーが発生したことをユーザーに通知するようにしました。
2019-02-23 21 15 02

関連Issue

resolve #184

詳細

対象ページ

TodoList

特にレビューしてほしいところ

その他

rechtburg
rechtburg approved these changes Feb 23, 2019
View reviewed changes
Copy link
Contributor

@rechtburg rechtburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bokusunny bokusunny merged commit 947c1a4 into master Feb 23, 2019
@bokusunny bokusunny deleted the handle_bug branch February 23, 2019 12:22
@bokusunny bokusunny mentioned this pull request Feb 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rechtburg rechtburg rechtburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

恒星&惑星を破壊しようとするとエラーが発生する
2 participants
@bokusunny @rechtburg