Skip to content

Commit

Permalink
wdio-sync: Cleanup stacktraces (webdriverio#3750)
Browse files Browse the repository at this point in the history
## Proposed changes

Remove stacktraces from webdriverio files.

Before:
```
element ("body") still not displayed after 30000ms
Error: element ("body") still not displayed after 30000ms
    at timer.catch.e (/focus/node_modules/webdriverio/build/commands/browser/waitUntil.js:69:15)
    at Element.waitForDisplayed (/focus/node_modules/webdriverio/build/commands/element/waitForDisplayed.js:51:15)
    at FinalGrades.waitForDisplayed [as openTemplate] (/focus/sis/modules/Grades/FinalGrades/page-classes/FinalGrades.js:137:23)
    at Context.openTemplate (/focus/sis/modules/Users/Profiles/tests/FOCUS-19414.js:102:15)
```

After:
```
element ("body") still not displayed after 30000ms
Error: element ("body") still not displayed after 30000ms
    at FinalGrades.waitForDisplayed [as openTemplate] (/focus/sis/modules/Grades/FinalGrades/page-classes/FinalGrades.js:137:23)
    at Context.openTemplate (/focus/sis/modules/Users/Profiles/tests/FOCUS-19414.js:102:15)
```

## Types of changes

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist

- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)

### Reviewers: @webdriverio/technical-committee
  • Loading branch information
WillBrock authored and christian-bromann committed Mar 25, 2019
1 parent c96d828 commit e3147b9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/wdio-sync/src/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const STACKTRACE_FILTER = [
// exclude @wdio/sync from stack traces
'node_modules/@wdio/sync/',

// exclude middlewares
'node_modules/webdriverio/build/middlewares.js',
// exclude webdriverio stack traces
'node_modules/webdriverio/build/',

// exclude Request emit
' (events.js:',
Expand Down

0 comments on commit e3147b9

Please sign in to comment.