wdio-sync: Cleanup stacktraces #3750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3750 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 145 145
Lines 3314 3314
Branches 726 726
=======================================
Hits 3259 3259
Misses 50 50
Partials 5 5
Continue to review full report at Codecov.
|
|
I think that cutting logs to much is not really good idea. Can't see nothing bad to see what has failed in webdriverio. I don't mind optimising stack traces but would avoid cutting them fully |
|
I don't think it provides any benefit to the end user with seeing the files from the framework and just adds clutter. If I recall correctly other frameworks exclude the stacktraces from their internal files. |
christian-bromann
added
the
PR: Polish 💅
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
## Proposed changes
Remove stacktraces from webdriverio files.
Before:
```
element ("body") still not displayed after 30000ms
Error: element ("body") still not displayed after 30000ms
at timer.catch.e (/focus/node_modules/webdriverio/build/commands/browser/waitUntil.js:69:15)
at Element.waitForDisplayed (/focus/node_modules/webdriverio/build/commands/element/waitForDisplayed.js:51:15)
at FinalGrades.waitForDisplayed [as openTemplate] (/focus/sis/modules/Grades/FinalGrades/page-classes/FinalGrades.js:137:23)
at Context.openTemplate (/focus/sis/modules/Users/Profiles/tests/FOCUS-19414.js:102:15)
```
After:
```
element ("body") still not displayed after 30000ms
Error: element ("body") still not displayed after 30000ms
at FinalGrades.waitForDisplayed [as openTemplate] (/focus/sis/modules/Grades/FinalGrades/page-classes/FinalGrades.js:137:23)
at Context.openTemplate (/focus/sis/modules/Users/Profiles/tests/FOCUS-19414.js:102:15)
```
## Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
## Checklist
- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
### Reviewers: @webdriverio/technical-committee
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove stacktraces from webdriverio files.
Before:
After:
Types of changes
Checklist
Reviewers: @webdriverio/technical-committee