Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version conflict with snowplow in telemetry #39

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

GabrielXia
Copy link
Contributor

Exclude the jackson in CR-core, and include newer version in engine to test snowplow tracker for telemetry. CR still works.

@Cervator
Copy link
Member

Can confirm this PR works fine using a Terasology workspace with the CR embedded as source (/lib/CrashReporter) - however, would it cause issues with DestinationSol, which also uses the CR, if we make an assumption that the consumer provides jackson ?

The dependencies for DS are pretty limited, pretty much just our stuff and LibGDX, although I can't remember if LibGDX ships with fat jars instead of transitive dependencies - the dependency tree looks like so:

compile - Dependencies for source set 'main'.
+--- com.badlogicgames.gdx:gdx:1.7.0                                       
+--- com.badlogicgames.gdx:gdx-box2d:1.7.0
|    \--- com.badlogicgames.gdx:gdx:1.7.0
+--- com.badlogicgames.gdx:gdx-controllers:1.7.0
|    \--- com.badlogicgames.gdx:gdx:1.7.0
+--- org.terasology:gestalt-module:6.0.0
|    +--- org.slf4j:slf4j-api:1.7.21
|    +--- com.google.guava:guava:19.0
|    +--- org.terasology:gestalt-util:6.0.0
|    |    +--- org.slf4j:slf4j-api:1.7.21
|    |    +--- com.google.guava:guava:19.0
|    |    \--- com.googlecode.gentyref:gentyref:1.2.0
|    +--- org.reflections:reflections:0.9.10
|    |    +--- com.google.guava:guava:18.0 -> 19.0
|    |    +--- org.javassist:javassist:3.18.2-GA
|    |    \--- com.google.code.findbugs:annotations:2.0.1
|    +--- com.google.code.gson:gson:2.5
|    +--- dom4j:dom4j:1.6.1
|    |    \--- xml-apis:xml-apis:1.0.b2
|    \--- org.apache.commons:commons-vfs2:2.0
|         +--- commons-logging:commons-logging:1.1.1
|         +--- org.apache.maven.scm:maven-scm-api:1.4
|         |    \--- org.codehaus.plexus:plexus-utils:1.5.6
|         \--- org.apache.maven.scm:maven-scm-provider-svnexe:1.4
|              +--- org.apache.maven.scm:maven-scm-provider-svn-commons:1.4
|              |    +--- org.apache.maven.scm:maven-scm-api:1.4 (*)
|              |    \--- org.codehaus.plexus:plexus-utils:1.5.6
|              +--- regexp:regexp:1.3
|              +--- org.apache.maven.scm:maven-scm-api:1.4 (*)
|              \--- org.codehaus.plexus:plexus-utils:1.5.6
\--- org.terasology:gestalt-asset-core:6.0.0
     +--- org.slf4j:slf4j-api:1.7.21
     +--- com.google.guava:guava:19.0
     +--- org.terasology:gestalt-util:6.0.0 (*)
     \--- org.terasology:gestalt-module:6.0.0 (*)

Might it be a better option to exclude the transitive dependency on jackson in the CR when it is declared as a dependency for Terasology? That's doable in Gradle and I might be able to figure it out if that sounds right.

Pinging @skaldarnar and @msteiger

@Cervator Cervator added this to the v4.1.1 milestone Jul 17, 2017
@Cervator Cervator merged commit 36cf236 into MovingBlocks:develop Jul 17, 2017
Cervator added a commit that referenced this pull request Jul 17, 2017
@Cervator
Copy link
Member

Okay after a fair bit of time playing with Gradle on the Terasology side of things I finally went back over here and made this tweak conditional instead. For some reason I can make Gradle behave for Terasology when editing transitive dependencies (which Jackson here is an example of) but IntelliJ won't listen and remains unchanged, then crashes. So merged with an edit in 9d745a5 - thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants