perf: replace stream with for loop when retrieving facets. (#4780)

Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
MovingBlocks · Jun 20, 2021 · 65c5d39 · 65c5d39
1 parent e11c4f7
commit 65c5d39
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/engine/src/main/java/org/terasology/engine/world/generation/RegionImpl.java b/engine/src/main/java/org/terasology/engine/world/generation/RegionImpl.java
@@ -35,14 +35,16 @@ public RegionImpl(BlockRegion region,
     public <T extends WorldFacet> T getFacet(Class<T> dataType) {
         T facet = generatedFacets.getInstance(dataType);
         if (facet == null) {
-            facetProviderChains.get(dataType).stream().filter(provider -> !processedProviders.contains(provider)).forEach(provider -> {
-                if (scale == 1) {
-                    provider.process(this);
-                } else {
-                    ((ScalableFacetProvider) provider).process(this, scale);
+            for (FacetProvider provider : facetProviderChains.get(dataType)) {
+                if (!processedProviders.contains(provider)) {
+                    if (scale == 1) {
+                        provider.process(this);
+                    } else {
+                        ((ScalableFacetProvider) provider).process(this, scale);
+                    }
+                    processedProviders.add(provider);
                 }
-                processedProviders.add(provider);
-            });
+            }
             facet = generatingFacets.getInstance(dataType);
             generatedFacets.put(dataType, facet);
         }