chore: reusue Floatbuffer for uniform (#4762)

MovingBlocks · Jun 15, 2021 · 718c2ff · 718c2ff
1 parent 49a3add
commit 718c2ff
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/engine/src/main/java/org/terasology/engine/rendering/opengl/GLSLMaterial.java b/engine/src/main/java/org/terasology/engine/rendering/opengl/GLSLMaterial.java
@@ -61,6 +61,8 @@ public class GLSLMaterial extends BaseMaterial {
     private DisposalAction disposalAction;
     private MaterialData materialData;
 
+    private final FloatBuffer matrixBuffer = BufferUtils.createFloatBuffer(16);
+
     public GLSLMaterial(ResourceUrn urn, AssetType<?, MaterialData> assetType, MaterialData data,
                         LwjglGraphicsProcessing graphicsProcessing, GLSLMaterial.DisposalAction disposalAction) {
         super(urn, assetType, disposalAction);
@@ -481,20 +483,20 @@ public void setMatrix3(String desc, Matrix3fc value, boolean currentOnly) {
         if (isDisposed()) {
             return;
         }
-        FloatBuffer buffer = BufferUtils.createFloatBuffer(16);
-        value.get(buffer);
+        matrixBuffer.rewind();
+        value.get(matrixBuffer);
         if (currentOnly) {
             enable();
             int id = getUniformLocation(getActiveShaderProgramId(), desc);
-            GL20.glUniformMatrix3fv(id, false, buffer);
+            GL20.glUniformMatrix3fv(id, false, matrixBuffer);
         } else {
             TIntIntIterator it = disposalAction.shaderPrograms.iterator();
             while (it.hasNext()) {
                 it.advance();
 
                 GL20.glUseProgram(it.value());
                 int id = getUniformLocation(it.value(), desc);
-                GL20.glUniformMatrix3fv(id, false, buffer);
+                GL20.glUniformMatrix3fv(id, false, matrixBuffer);
             }
 
             restoreStateAfterUniformsSet();
@@ -529,20 +531,20 @@ public void setMatrix4(String desc, Matrix4fc value, boolean currentOnly) {
         if (isDisposed()) {
             return;
         }
-        FloatBuffer buffer = BufferUtils.createFloatBuffer(16);
-        value.get(buffer);
+        matrixBuffer.rewind();
+        value.get(matrixBuffer);
         if (currentOnly) {
             enable();
             int id = getUniformLocation(getActiveShaderProgramId(), desc);
-            GL20.glUniformMatrix4fv(id, false, buffer);
+            GL20.glUniformMatrix4fv(id, false, matrixBuffer);
         } else {
             TIntIntIterator it = disposalAction.shaderPrograms.iterator();
             while (it.hasNext()) {
                 it.advance();
 
                 GL20.glUseProgram(it.value());
                 int id = getUniformLocation(it.value(), desc);
-                GL20.glUniformMatrix4fv(id, false, buffer);
+                GL20.glUniformMatrix4fv(id, false, matrixBuffer);
             }
 
             restoreStateAfterUniformsSet();