chore: address some checkstyle warnings (#4869)

I saw a couple of Checkstyle warnings popping up when reviewing #4853. This addresses a couple of the simpler ones, like removing unused imports or removing unused variables.
MovingBlocks · Aug 27, 2021 · aa72c28 · aa72c28
1 parent ff09113
commit aa72c28
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 17 deletions.
diff --git a/engine/src/main/java/org/terasology/engine/input/cameraTarget/CameraTargetSystem.java b/engine/src/main/java/org/terasology/engine/input/cameraTarget/CameraTargetSystem.java
@@ -16,7 +16,6 @@
 import org.terasology.engine.physics.Physics;
 import org.terasology.engine.physics.StandardCollisionGroup;
 import org.terasology.engine.registry.In;
-import org.terasology.engine.rendering.world.WorldRenderer;
 import org.terasology.engine.world.BlockEntityRegistry;
 import org.terasology.engine.world.block.BlockComponent;
 import org.terasology.math.TeraMath;
@@ -34,9 +33,6 @@ public class CameraTargetSystem extends BaseComponentSystem {
     @In
     private Config config;
 
-    @In
-    private WorldRenderer worldRenderer;
-
     @In
     private Physics physics;
 

diff --git a/engine/src/main/java/org/terasology/engine/logic/characters/CharacterSystem.java b/engine/src/main/java/org/terasology/engine/logic/characters/CharacterSystem.java
@@ -18,7 +18,6 @@
 import org.terasology.engine.entitySystem.systems.RegisterSystem;
 import org.terasology.engine.entitySystem.systems.UpdateSubscriberSystem;
 import org.terasology.engine.input.binds.interaction.AttackButton;
-import org.terasology.engine.input.cameraTarget.PlayerTargetSystem;
 import org.terasology.engine.logic.characters.events.ActivationRequest;
 import org.terasology.engine.logic.characters.events.ActivationRequestDenied;
 import org.terasology.engine.logic.characters.events.AttackEvent;
@@ -48,13 +47,11 @@
 import org.terasology.engine.recording.RecordAndReplayCurrentStatus;
 import org.terasology.engine.recording.RecordAndReplayStatus;
 import org.terasology.engine.registry.In;
-import org.terasology.engine.world.BlockEntityRegistry;
 import org.terasology.engine.world.block.BlockComponent;
 import org.terasology.engine.world.block.regions.ActAsBlockComponent;
 
 import java.util.Optional;
 
-
 @RegisterSystem
 public class CharacterSystem extends BaseComponentSystem implements UpdateSubscriberSystem {
     public static final CollisionGroup[] DEFAULTPHYSICSFILTER =
@@ -76,12 +73,6 @@ public class CharacterSystem extends BaseComponentSystem implements UpdateSubscr
     @In
     private Time time;
 
-    @In
-    private PlayerTargetSystem targetSystem;
-
-    @In
-    private BlockEntityRegistry blockRegistry;
-
     @In
     private DirectionAndOriginPosRecorderList directionAndOriginPosRecorderList;
 

diff --git a/engine/src/main/java/org/terasology/engine/logic/characters/KinematicCharacterMover.java b/engine/src/main/java/org/terasology/engine/logic/characters/KinematicCharacterMover.java
@@ -7,8 +7,6 @@
 import org.joml.RoundingMode;
 import org.joml.Vector3f;
 import org.joml.Vector3i;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.terasology.engine.entitySystem.entity.EntityRef;
 import org.terasology.engine.logic.characters.events.FootstepEvent;
 import org.terasology.engine.logic.characters.events.HorizontalCollisionEvent;
@@ -17,13 +15,13 @@
 import org.terasology.engine.logic.characters.events.SwimStrokeEvent;
 import org.terasology.engine.logic.characters.events.VerticalCollisionEvent;
 import org.terasology.engine.logic.location.LocationComponent;
-import org.terasology.math.TeraMath;
 import org.terasology.engine.physics.engine.CharacterCollider;
 import org.terasology.engine.physics.engine.PhysicsEngine;
 import org.terasology.engine.physics.engine.SweepCallback;
 import org.terasology.engine.physics.events.MovedEvent;
 import org.terasology.engine.world.WorldProvider;
 import org.terasology.engine.world.block.Block;
+import org.terasology.math.TeraMath;
 
 /**
  * Calculates character movement using a physics-engine provided CharacterCollider.
@@ -66,7 +64,6 @@ public class KinematicCharacterMover implements CharacterMover {
     public static final float VERTICAL_PENETRATION_LEEWAY = 0.05f;
     private static final float CHECK_FORWARD_DIST = 0.05f;
 
-    private static final Logger logger = LoggerFactory.getLogger(KinematicCharacterMover.class);
     private boolean stepped;
 
     // Processing state variables