Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass can grow on ... water? #1030

Closed
Cervator opened this issue Mar 23, 2014 · 2 comments
Closed

Grass can grow on ... water? #1030

Cervator opened this issue Mar 23, 2014 · 2 comments
Labels
Type: Bug Issues reporting and PRs fixing problems

Comments

@Cervator
Copy link
Member

Noticed this by chance - it probably speaks for itself!

terasology-140322164427-1152x700

I imagine that's a simple check that can be added somewhere to prevent .. :-)

Edit: As per correction on IRC the issue is having water pockets generate below grass, which may be going away soon anyway! We've needed a new approach for a long time

@Sk0ut
Copy link
Contributor

Sk0ut commented Nov 20, 2015

Hi, Cervator, I'm one of the students from Porto and I've taken interest in solving this bug.
If I understand the problem in here, when the world is generated, it may happen that water pockets are generated below grass because there's no check above the selected position for the water pockets.
Is this right?

@Cervator
Copy link
Member Author

Hi @Sk0ut - I'm not actually sure if this issue is valid anymore. I think this was the "old" Perlin generator. We then overhauled world generation to use facets, which you can read about in https://github.com/Terasology/TutorialWorldGeneration/

I don't think we actually generate pockets of water like that in the new Perlin. I'll close this as out of date.

If you're interested in world generation the tutorial I linked above for the new system is great and makes working on world gen quite approachable. Try going through it step by step and see how you like it :-)

We have #1193 for restoring some of the old Perlin features, with a linked forum thread: http://forum.terasology.org/threads/core-perlin-world-improvements.1093 - there are also some great world gen features in https://github.com/Terasology/PolyWorld/ and https://github.com/Terasology/Cities/

If you would like you could add something simple back to the Perlin generator. Like for instance small puddles of water, or even lakes. Both PolyWorld and Cities have nice lakes. The forum thread has more ideas :-)

In any case just let us know if you have questions or would like guidance on finding something else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

No branches or pull requests

2 participants