Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBlockForPlacment for MultiConnectFamily will always throws an exception #4319

Closed
pollend opened this issue Dec 13, 2020 · 0 comments · Fixed by #4352
Closed

getBlockForPlacment for MultiConnectFamily will always throws an exception #4319

pollend opened this issue Dec 13, 2020 · 0 comments · Fixed by #4352
Milestone
v4.2.0

Comments

@pollend
Copy link
Member

pollend commented Dec 13, 2020

this method will always throw an exception. There is an explicit nullcheck for BlockPlacementData(Vector3ic blockPosition, Side attachmentSide, Vector3fc viewingDirection).

https://github.com/MovingBlocks/Terasology/blob/develop/engine/src/main/java/org/terasology/world/block/family/MultiConnectFamily.java#L192-L196
@pollend pollend changed the title getBlockForPlacment for MultiConnectFamily will always throw an exception getBlockForPlacment for MultiConnectFamily will always throws an exception Dec 13, 2020
This was referenced Dec 29, 2020
Merged
Merged
skaldarnar pushed a commit that referenced this issue Dec 30, 2020
@pollend
fix(#4319): add attchmentSide to getBlockForPlacement (#4352)
e796f62
@Cervator Cervator added this to the v4.2.0 milestone Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging a pull request may close this issue.

fix(#4319): add attchmentSide to getBlockForPlacement pollend/Terasology
2 participants
@pollend @Cervator