-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick follow-up to issue #446 - rail stuff #449
Comments
Another nicety would be allowing side-arrows to work on ladders if you're facing sideways from said ladder. So if you're facing left with the ladder on your right the right arrow would move you up the ladder and left arrow move you down :-) |
Different lit blocks depending on placement are not only a problem for rail, but also for any other blocks. It becomes most apparent when you look at different placed "halfblocks". Probably worth an own issue? |
Yes, the lighting problems are a more fundamental issue. Not sure what is going on yet, but it looks like either texcoords are being used in a way they shouldn't or normals are being messed up during rotation. A related issue is that some of our blocks, like the halfBlock, have not been marked as having symmetric collision. If collision is marked as symmetric, then when a block family is generated through combining a shapeless block with the shape only one block is created (a symmetric family). Otherwise a horizontal block family is created. This means that we are generating more blocks than are necessary - there is no need for multiple rotations of a half block for instance (unless the textures are different on different sides, but that requires an actual block definition). @AWFeldick when you have some time would you mind updating your block shapes? It is the "Is Collision Symmetric" flag in Blender (or you can add it directly in the shape json if you don't have the originals). |
Ok, I think I have the lighting issue fixed. Caused by some floating point errors in the ambient occlusion code in the chunk tessellator. |
|
Thanks guys :-) I tweaked the first post a bit. Actually got the checkboxes working this time, yay ;-) |
Hey, sure thing. I didn't know that the "Is collision symmetric" has optimizing effects. Oh, and wow immortius. You are fast! |
👍 |
Split out the remaining sub-items to their own issues so closing this I have a vague suspicion that adding the collision symmetric to some of the flat blocks may have made them render differently in other ways than just fixing lighting quirks - opaque ladders on walls and ladders/tracks invisible in hand - but I haven't verified that, just believe I recall not having those issues back when this was filed :-) |
Pulled #446 just now but there are a few tweaks needed sometime :-)
The text was updated successfully, but these errors were encountered: