Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request - Cleanup #247

Closed
wants to merge 24 commits into from
Closed

Pull Request - Cleanup #247

wants to merge 24 commits into from

Conversation

R41D3NN
Copy link
Contributor

@R41D3NN R41D3NN commented May 23, 2012

Heya, this collection up commits basically does only one thing: removed unused and organized imports. Take a look and see if yall like.

@R41D3NN
Copy link
Contributor Author

R41D3NN commented May 23, 2012

Sorry about the excessive commits. It took me time to figure out I would be doing the same thing among a large portion of files. :)

@Cervator
Copy link
Member

Yeah that's a lot of commits! :D

In theory here I believe you'd use git rebase to squash all those commits into a single big commit. But honestly I'm not even comfortable enough with Git myself to really try that myself if I had a bunch of excess commits.

Actual changes look good tho. Won't get to it tonight, but prolly tomorrow. Thanks!

@R41D3NN
Copy link
Contributor Author

R41D3NN commented May 24, 2012

Yeah, I am not too comfortable doing that myself either... Some things are better left tinkered with less significant work. I will mess around with a pseudo project and see how compressing commits works.

@Cervator
Copy link
Member

Popped a quick discussion over in http://forum.movingblocks.net/threads/new-organized-documented-coding-conventions-practices.304/#post-2690 seeing some of those ambiguously evil curly brackets biting the dust in this pull :-)

Should .gitignore itself really be in .gitignore tho? We occasionally do need to update that.

@R41D3NN
Copy link
Contributor Author

R41D3NN commented May 25, 2012

Oops. I forgot to undo that because I had some content that I didn't want shown it my diff and it just slipped my mind. I will rework this pull and get back to you.

@R41D3NN R41D3NN closed this May 25, 2012
@Cervator
Copy link
Member

Thanks! Very much appreciated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants