New create game flow backend | Final steps #3385
Conversation
TheFlash98
changed the title
|
Hooray Jenkins reported success with all tests good! |
There was a problem hiding this comment.
One tiny comment about a variable that can be addressed in the future if valid (pinging @vampcat)
In a future PR we might want to disable or hide some elements until they're implemented, like world shape and the time progression slider :-)
Maybe the popup on clicking reroll could be removed as well. May be smoother UX just going without.
Reminder also to move the "Accept" button on world setup down next to the "Back" button (and maybe rename that one "Cancel" ?)
Anyway nothing in the way of merging this right now so we can update the board and start on cool new stuff as well :-) Nice work!
| @@ -85,7 +86,7 @@ public void initialise() { | |||
|
|
|||
| SimpleUri uri = world.getWorldGeneratorInfo().getUri(); | |||
| // This is multiplied by the number of seconds in a day (86400000) to determine the exact millisecond at which the game will start. | |||
| float timeOffset = 0.50f; | |||
| final float timeOffset = 0.50f; | |||
There was a problem hiding this comment.
Unsure if @vampcat meant to make this a constant rather than just final. If so it would be all caps and so on as a class level variable :-)
|
Hooray Jenkins reported success with all tests good! |
Contains
Nothing new to review in this PR compared to #3383 I've only addressed the review by vampcat. Will be pushing the last few things needed for the create game flow here.
Outstanding before merging
Could use some help in the above-mentioned issues. :)