Fix getText() function in UIText

[darshan3]

Contains

Fixes #3688

How to test

Start from a clean game with no save games. Try reproducing #3688, in both the ways stated over there. The new game should load properly now.

[darshan3]

The getText() function was incorrectly adding a '\n' character, which leads to parsing error GameProvider.getNextGameName(). Hence, when it incorrectly returns the game name as 'Game 1' even if saved games are present with the same name. This leads to further errors in loading and saving the game in the same directory.

[darshan3]

I would also request @jellysnake or @eviltak to have a look once since I don't know how multiline text works and haven't tested it out for the changes in this pr.

[skaldarnar]

In this case text.get() is the empty string "" - why are we prepending a newline here? Should it rather be:

 if (text.get().equals("")) {
    return arrayText;
} else {
    return text.get() + "\n" + arrayText;
}

[darshan3]

My mistake, it should be !text.get().equals(""). I will fix it.

[darshan3]

Should I just return arrayText instead of text.get() + arrayText? There was a discussion in original pr #3678 regarding this but resolved eventually.

[Cervator]

Tested out a fair bit - merging! :-)

Since this fixes a blocker I figure merge sooner, ask more questions later if needed. Existing saves may still cause problems even after the fix (since I guess a bad name might persist that way) but in a clean workspace I didn't see any issues colliding with new saves.

[eviltak]

Reverted with #3678.