Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replicate NameTagComponent fields to clients, to fix name tag display issues in multiplayer #4080

Merged
merged 1 commit into from Jul 13, 2020
Merged

Replicate NameTagComponent fields to clients, to fix name tag display issues in multiplayer #4080

merged 1 commit into from Jul 13, 2020

Conversation

AndyTechGuy
Copy link
Contributor

Adds an @Replicate annotation to all fields of NameTagComponent. This replicates the name tag information from server to clients, so the all clients see newly generated name tags.

How to test

  • Join a host game/join game world with two clients, using a module that dynamically generates name tags. (Terasology/MetalRenegades generates city names this way)
  • When the name is generated, it should appear the same on both clients.

@jdrueckert
Copy link
Member

Successfully checked, that the test failure was not introduced by this PR.

@jdrueckert jdrueckert merged commit 799f432 into MovingBlocks:develop Jul 13, 2020
@Cervator Cervator added Multiplayer Affects aspects not visible in Singleplayer mode only Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience labels Jul 13, 2020
@Cervator Cervator added this to the v4.0.0 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert jdrueckert approved these changes

Assignees
No one assigned
Labels
Multiplayer Affects aspects not visible in Singleplayer mode only Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndyTechGuy @jdrueckert @Cervator