New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking all] Gestalt v7 re-integration.... #4144
Conversation
… First fix - fix imports.
fix problems for engine module as package module
a98fe46
to
eef934f
Compare
… FileSystem in TempFolder
…y.engine` - for better PackageModule handling
…e reflections for gestaltv7)
…tch. add synthetic nui module. add gestalt's classes to Whitelist
…n *.ui files for nui module)
Why was moving things from org.terasology to org.terasology.engine necessary? It'll probably conflict with every other PR in a way that'll be awkward to fix, and the majority of module PRs too, and it makes it harder to find the actual changes in this PR to review it. Github isn't even able to detect the files a moved. Is there really no other way to do this? |
return result; | ||
} | ||
} | ||
///* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a better way of dealing with this than commenting out the entire file. Isn't there some mechanism for ignoring tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a better way of dealing with this than commenting out the entire file. Isn't there some mechanism for ignoring tests?
It is draft PR. :P
Compile time problems.
This test and ModuleListDownloader will be reimplemented for gestalt v7
Gestalt v7 haven't classpath modules now (which works via detects ProtectedDomain of module.txt file). I will mark changes in PRs. |
# Conflicts: # engine-tests/src/test/java/org/terasology/logic/location/LocationComponentTest.java # engine/src/main/java/org/terasology/logic/location/LocationComponent.java # engine/src/main/java/org/terasology/math/Direction.java
oh geez, how am I going to review this. I'm guessing it'll be a matter of looking at some specific commits, instead of the whole batch, and/or doing a diff of some specific sub-packages? suggestions of which packages to look at? Just as a wild guess based on what I think gestalt does: persistence, reflection, core.module? anything else? |
Contains
Re-integration gestaltv7
org.terasology.engine
now)BaseModule
class)Module#isSourceModule
to checking Module's files source ==DirectoryFileSource
- must be equal ( affected WorldGeneratorManager)org.terasology.input
(org.terasology.engine.input
now). We have this classes in TeraNUIcacheReflections
task on afterclasses
task (partial resolve Substantial performance issues in latest JS, possibly spawning at 0,0,0 in multiplayer #4126 (comment)) (reflections gathering for running from sources now)cleanReflections
afterjar
taskcacheReflections
's artifactreflections.cache
tomanifest.json
and serializer changed to Json for using gestaltv7's default valuesFixes #2445
Testing
Check annotation marked classes reloading (e.g. WorldGenerator)
Check assets reloading
Check module downloading
Fast check for 70% sure that game works
gradlew test
Check guava 29.0-jre :
6.* Check what everything works fine:
Outstanding before merging
Linked PRs
MovingBlocks/TeraNUI#27