Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Has/Cancel/Add DelayedActionEvent #4166

Merged
merged 1 commit into from Oct 18, 2020

Conversation

pollend
Copy link
Member

@pollend pollend commented Oct 1, 2020

These action events are not used anywhere in omega. seems like a good time to remove them from the engine. There might be some older modules using this but, at this point its probably just better to rework/rebuild them at this point.

Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm, looks fine to me. Reminded me of some funny naming issues elsewhere but that's not relevant to merging this or not.

@Cervator Cervator added Api Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. labels Oct 18, 2020
@Cervator Cervator added this to the v4.1.0 milestone Oct 18, 2020
@Cervator Cervator merged commit 4365112 into MovingBlocks:develop Oct 18, 2020
@skaldarnar skaldarnar removed the Api label May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants