tweak sort for validating chunk n^2 cost #4179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this sort for chunk relevance adds an n^2 cost to the search. since it will try to sort the current chunks against all possible nearby chunks. this function only add the chunk from the region if its valid or creates a new chunk if its not available. This same problem is also apparent with
ChunkTaskRelevanceComparator
. Some better strategies would need to be setup if there are a lot of relevant entities.