Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle-server): restore missing suffix for jvmarg -Xmx #4212

Merged
merged 1 commit into from Oct 21, 2020

Conversation

DarkWeird
Copy link
Contributor

@DarkWeird DarkWeird commented Oct 21, 2020

Contains

Fix jvmArgs for server gradle task.
Bug prevent server to start with error:

Error occurred during initialization of VM
Too small maximum heap

introduced in #4175

How to test

  1. Checkout it
  2. run server task.
  3. check that server started (any output from server)

@DarkWeird DarkWeird added the Type: Bug Issues reporting and PRs fixing problems label Oct 21, 2020
@skaldarnar skaldarnar merged commit 644ed2c into develop Oct 21, 2020
@skaldarnar skaldarnar deleted the fix/fix-gradle-server branch October 21, 2020 14:58
@keturn
Copy link
Member

keturn commented Oct 21, 2020

Thank you for this, @DarkWeird. It was sloppy of me. I had been thinking that it was too small because other reasons, not because I had made a typo to only allocate 1,536 bytes. 😭

@DarkWeird
Copy link
Contributor Author

Thank you for this, @DarkWeird. It was sloppy of me. I had been thinking that it was too small because other reasons, not because I had made a typo to only allocate 1,536 bytes. 😭

Yeah I thought that too at first.
I began to suspect later

@Cervator Cervator added this to the v4.1.0 milestone Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants